Readme update and locally MacOS test (install from repo)#10
Open
lexiyutou wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the installation instructions and improves the setup scripts for the PRIMA project, making it easier and more reliable to install and run both from PyPI and from source. The README is clarified for different install scenarios, and the
clean_install_local.shscript is enhanced for better Python and PyTorch version handling, as well as more robust dependency installation.Installation and environment improvements:
clean_install_local.shscript now prioritizes Python 3.10, adds more fallback paths for Python executables, and includes Python 3.12 as a last resort. Error messages and usage hints for Python selection are improved.Dependency management enhancements:
numpybeforextcocotoolsto ensure build success, installsxtcocotoolswith--no-build-isolation, and excludes it from the main requirements install to avoid duplicate/conflicting installations.Data setup and user experience:
--forceand--skip-dataoptions.Minor documentation tweaks:
These changes make the installation process more robust, especially for new users and those working on different platforms or with varied CUDA setups.