Fix: Include FIPS-updates repo in security source list (#337)#338
Open
Rkoffer-SMX wants to merge 1 commit into
Open
Fix: Include FIPS-updates repo in security source list (#337)#338Rkoffer-SMX wants to merge 1 commit into
Rkoffer-SMX wants to merge 1 commit into
Conversation
The security source list filter excluded FIPS-updates repos because they use suite names like "jammy-updates" instead of "jammy-security". This caused apt to resolve packages from jammy-security during installation, replacing FIPS-certified packages with non-FIPS versions. Broadens the filter in both one-line and DEB882-style source list readers to also retain lines/stanzas containing "fips-updates".
Rkoffer-SMX
requested review from
kjohn-msft,
najams and
rane-rajasi
as code owners
Author
|
@microsoft-github-policy-service agree company="SMX" |
kjohn-msft
approved these changes
Apr 26, 2026
yashnap
reviewed
May 4, 2026
rane-rajasi
approved these changes
May 5, 2026
kjohn-msft
approved these changes
May 6, 2026
yashnap
approved these changes
May 7, 2026
yashnap
added a commit
that referenced
this pull request
Jun 3, 2026
Refer to the old PR : #338 for more Information. Created PR because the original PR was lacking essentials checks : Suspicion is that since it was created from fork it didn't run essential checks marking it as unable to merge. Proof Test: **Failing** Created PR from my fork : #349 - It fails on Upload coverage to Codecov step : https://github.com/Azure/LinuxPatchExtension/actions/runs/26290421614/job/77388883207?pr=349 with the below error <img width="1396" height="407" alt="notoken" src="https://github.com/user-attachments/assets/d74cdcce-ff8e-4d7d-848d-c3591224e0fb" /> **Success** For successful PR : https://github.com/Azure/LinuxPatchExtension/actions/runs/26258749218/job/77287296261?pr=348 <img width="1436" height="483" alt="tokenfound" src="https://github.com/user-attachments/assets/fb133c86-7efb-41d1-8584-7057563da57a" /> Plausible reason: It is failing to get the Codecov secret Token when run from fork : CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security source list filter excluded FIPS-updates repos because they use suite names like "jammy-updates" instead of "jammy-security". This caused apt to resolve packages from jammy-security during installation, replacing FIPS-certified packages with non-FIPS versions.
Broadens the filter in both one-line and DEB882-style source list readers to also retain lines/stanzas containing "fips-updates".