Remove tinyxml2 vendor on rolling#1135
Open
mini-1235 wants to merge 5 commits into
Open
Conversation
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Contributor
Author
|
It looks like the issue is also due to rolling moved to Ubuntu Resolute, this causes issue when running rosdep on Noble. But I still think this PR is useful, since tinyxml2_vendor is expected to be removed in the future (if I remember correctly, around the Lyrical release) |
Collaborator
|
rolling CI is still failing |
Contributor
Author
I think there's something wrong with industrial ci and we might need to wait a few more weeks |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
mini-1235
commented
Jun 4, 2026
| matrix: | ||
| env: | ||
| - {ROS_DISTRO: rolling, ROS_REPO: main} | ||
| - {ROS_DISTRO: rolling, ROS_REPO: testing} |
Contributor
Author
There was a problem hiding this comment.
I just noticed that the ROS PMC is considering dropping support for the main repository in favor of the testing repository only for Rolling. The CI was failing earlier because there were no syncs for Rolling on 26.04, switching to the testing repo fixed it. Thoughts on this change? @facontidavide
Related:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Nav2, we are building BT.CPP from source temporarily, however, we are failing to build now:
I believe this is because tinyxml2_vendor is deprecated and removed on rolling, so I am removing this in rolling.
ref: https://github.com/open-planning/roboplan/blob/6987faf083d5b097b4251f8f698a1a7832c3ac86/roboplan/package.xml#L15-L16