Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 2 | Wireframe#1298

Open
gideondefar wants to merge 19 commits into
CodeYourFuture:mainfrom
gideondefar:feature/wireframe
Open

London | 26-ITP-May | Gideon Defar | Sprint 2 | Wireframe#1298
gideondefar wants to merge 19 commits into
CodeYourFuture:mainfrom
gideondefar:feature/wireframe

Conversation

@gideondefar
Copy link
Copy Markdown

@gideondefar gideondefar commented May 16, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I reviewed and resubmitted the wireframe exercise.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1bfbb95
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1ce9677b986f0008456a67
😎 Deploy Preview https://deploy-preview-1298--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gideondefar gideondefar changed the title Feature/wireframe London | 26-ITP-May | Gideon Defar | Sprint 2 | Wireframe May 16, 2026
@github-actions

This comment has been minimized.

@gideondefar gideondefar added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 16, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026
@github-actions

This comment has been minimized.

@gideondefar gideondefar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your branch is 16 commits behind the CYF's main. Can you update it? Some of the requirements have changed.

  • One of the new requirements is that each article should have a unique image. Can you address this issue?

  • Some of the code is not consistently formatted. Please follow this guide to
    enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 24, 2026
@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 31, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 31, 2026

This is how your current page look like on Netlify:

image

Its layout does not quite match the wireframe.

  • The images are "missing"
  • There should be a page title (and a short description beneath it) and both should be centered on the page
  • The footer content should also be centered

This branch is still not yet up to date. Please use the "Sync fork" button to keep it updated.

image

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 31, 2026
…, summaries, links and fix layout to match wireframe
@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 31, 2026
@gideondefar
Copy link
Copy Markdown
Author

I have synced the fork and updated the branch using the "Sync fork" button. The branch is now up to date with the latest changes. Please let me know if there is anything else to action.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 1, 2026

Code looks good.

This branch included a modified Form-Controls/index.html, which is not related to the Wireframe exercise.
Can you revert the change made to that file or restore the file to its original state?

I will mark this PR as complete first.


Here is one possible way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567.
The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 1, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@gideondefar gideondefar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 1, 2026

That works well. Good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants