London | 26-ITP-May | Gideon Defar | Sprint 2 | Wireframe#1298
London | 26-ITP-May | Gideon Defar | Sprint 2 | Wireframe#1298gideondefar wants to merge 19 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
-
Your branch is 16 commits behind the CYF's main. Can you update it? Some of the requirements have changed.
-
One of the new requirements is that each article should have a unique image. Can you address this issue?
-
Some of the code is not consistently formatted. Please follow this guide to
enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted.
…code consistently
|
This is how your current page look like on Netlify:
Its layout does not quite match the wireframe.
This branch is still not yet up to date. Please use the "Sync fork" button to keep it updated.
According to https://validator.w3.org/, there are errors in your code. Can you fix them? |
…, summaries, links and fix layout to match wireframe
f7dc9b7 to
03a7645
Compare
|
I have synced the fork and updated the branch using the "Sync fork" button. The branch is now up to date with the latest changes. Please let me know if there is anything else to action. |
|
Code looks good. This branch included a modified I will mark this PR as complete first. Here is one possible way to revert changes to a file is via the First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state. Next, record the first 7 characters of the commit SHA. Suppose the file is After the file is restored, make a commit and push the changes to GitHub. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
That works well. Good job. |



Learners, PR Template
Self checklist
Changelist
I reviewed and resubmitted the wireframe exercise.