London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Wireframe#1376
Open
cywong-dev wants to merge 4 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 2 | Wireframe#1376cywong-dev wants to merge 4 commits into
cywong-dev wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cywong-dev
added
the
Needs Review
cjyuan
reviewed
May 30, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
To better match the layout in the wireframe, can you make the title and the "Read More" links in articles 2 and 3 fully aligned horizontally?
- Note: If you have not yet enabled "Format on save" on VS Code, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
cjyuan
added
Reviewed
Changed the html file with <nav> for better display Changed the css file to the footer control with relative position instead of fixed position
cywong-dev
added
Needs Review
cjyuan
reviewed
Jun 3, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
The footer now no longer fixed at the bottom of the page. Can you address this issue so that the implementation meets all the requirement?
-
Your code is well formatted. In case you haven't yet enabled "Format on save" in VS Code, please consider to do so.
cjyuan
added
Reviewed
cjyuan
reviewed
Jun 3, 2026
replace the <br> with css margin correct the space in the href fixed the footer so that it can be displayed at the bottom of the page
cywong-dev
added
Needs Review
cjyuan
reviewed
Jun 4, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The footer is now fixed at the bottom of the page. Can you also ensure:
- The footer content is centered
- The footer content and the article content won't overlap
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed the changed based on the requirement