London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control#1388
Open
gideondefar wants to merge 16 commits into
Open
London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control#1388gideondefar wants to merge 16 commits into
gideondefar wants to merge 16 commits into
Conversation
Add a newline at the end of the HTML file.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
My pull request was labeled as completed, but there was a conflict of commits between my local and remote branches, where some commits were behind. I tried to sync fork, but it didn't work; then I merged the branch with the new PR. |
Luro91
reviewed
Jun 3, 2026
Luro91
left a comment
There was a problem hiding this comment.
Looks quite good. Only the minimum length needs to be fixed
akeren
reviewed
Jun 3, 2026
akeren
left a comment
There was a problem hiding this comment.
@gideondefar, any reason you didn't apply CSS to your semantic HTML form?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author
It was by mistake, but now I've sorted it out; they are successfully linked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Self checklist
Changelist
Text input for name, and email input for email with proper validation. Select inputs for color and size with pre-defined choices. Validated with Lighthouse.