London | 26-Mar-SDC | Craig D'Silva | Sprint 4 | Implement Shell Tools Python#482
Open
craig-dsilva wants to merge 16 commits into
Open
London | 26-Mar-SDC | Craig D'Silva | Sprint 4 | Implement Shell Tools Python#482craig-dsilva wants to merge 16 commits into
craig-dsilva wants to merge 16 commits into
Conversation
craig-dsilva
added
🦑 Size Large
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good implementations, but I think that you could be a bit cleaner when writing some of your logic. Notably, your use of booleans in if statements. Can you take another look at this?
| text_list = text.split("\n") | ||
| text_list.pop(len(text_list) - 1) | ||
|
|
||
| if (show_lines == False and non_blank == False): |
Contributor
There was a problem hiding this comment.
If you are testing booleans, is there a better way of writing these if statements?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement shell tool with Python