London | 26-SDC-March | Zobeir Rigi | Sprint 4 | Implement shell tools python#524
Open
Zobeir-Rigi wants to merge 8 commits into
Open
London | 26-SDC-March | Zobeir Rigi | Sprint 4 | Implement shell tools python#524Zobeir-Rigi wants to merge 8 commits into
Zobeir-Rigi wants to merge 8 commits into
Conversation
Zobeir-Rigi
added
the
Needs Review
LonMcGregor
reviewed
Jun 3, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there is some work left to do here.
Is there a package you could use to help with managing arguments? Right now it is a bit complex, and you can't combine single-letter arguments like the command line tools.
| elif arg != "-1": | ||
| path = arg | ||
|
|
||
| files = os.listdir(path) |
Contributor
There was a problem hiding this comment.
Part of this task is to see if you can handle the listing yourself.
| if arg == "-a": | ||
| show_all = True | ||
|
|
||
| elif arg != "-1": |
Contributor
There was a problem hiding this comment.
Is there any difference between when -1 is used and when not?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist