docs: Update docs custom ssr to use new instance instead of singleton#7653
Open
loic-masson wants to merge 1 commit into
Open
docs: Update docs custom ssr to use new instance instead of singleton#7653loic-masson wants to merge 1 commit into
loic-masson wants to merge 1 commit into
Conversation
|
@loic-masson is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Next.js and SSR integration documentation to include the initialization of a fresh Flagsmith instance per request using createFlagsmithInstance to prevent identity leaking across concurrent SSR requests. There are no review comments, and I have no feedback to provide.
loic-masson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Updating the documentation for custom SSR as I think it is a bit misleading.
I thought that the flagsmith init would be straight from flagsmith/isomorphic.
Which created issues in my SSR setup.
The documentation is showing to use createFlagsmithInstance which also reflects how the Next js is setup.
How did you test this code?
Just documentation changes.