fix: support decimal multivariate variation weights#7672
Open
SahilJat wants to merge 1 commit into
Open
Conversation
|
@SahilJat is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
Changes
Closes #7671
This PR enables support for decimal/fractional values in multivariate variation weights within the dashboard.
Key updates:
VariationValueInput.tsxto use a number input type withstep="any", allowing for decimal entry.parseIntwithparseFloatin the variation weight change handler to ensure decimal values are preserved in the state.calculateControlutility inutils.tsxto round the calculated control remainder to 2 decimal places, preventing floating-point precision artifacts (e.g.,0.09999999999999432) from appearing in the UI.How did you test this code?
type="text"totype="number"does not break existing automation that interacts with these fields.