Migrate fonts to resource system#4165
Open
timon-schelling wants to merge 11 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timon-schelling
force-pushed
the
fonts-as-resources
branch
2 times, most recently
from
e7f882e to
264a3f5
Compare
timon-schelling
force-pushed
the
fonts-as-resources
branch
from
264a3f5 to
6a19368
Compare
timon-schelling
force-pushed
the
fonts-as-resources
branch
from
6a19368 to
933229c
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
8 issues found across 43 files
Confidence score: 2/5
- Multiple high-severity, high-confidence issues indicate real regression risk:
closest_style()ineditor/src/messages/portfolio/fonts/utility_types.rscan panic on empty styles, and resource resolution paths ineditor/src/messages/portfolio/document/resource/resource_message_handler.rscan deadlock when pending state is not cleared. editor/src/messages/portfolio/portfolio_message_handler.rsintroduces a global unresolved-resource guard that can block unrelated document rendering, which is a broad user-facing failure mode rather than a localized edge case.- Font resource consistency also looks fragile: key normalization mismatch in
editor/src/messages/portfolio/fonts/fonts_message_handler.rsand duplicateResourceIdcreation ineditor/src/messages/portfolio/document/node_graph/node_properties.rscan make fonts unresolvable or duplicated. - Pay close attention to
editor/src/messages/portfolio/fonts/utility_types.rs,editor/src/messages/portfolio/document/resource/resource_message_handler.rs, andeditor/src/messages/portfolio/portfolio_message_handler.rs- panic/deadlock/global blocking behaviors are the main merge risks.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
2 issues found across 6 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
TrueDoctor
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.