Halscope: Fix setting for AC coupling (2.9)#4128
Open
hansu wants to merge 2 commits into
Open
Conversation
When opening the offset dialog with enabled AC coupling, the AC checkbox is unselected. You need to select and unselect it in order to disable AC coupling.
The offset was reset to zero when AC coupling was enabled. This adds a data field to restore the previous offset value when disabling AC coupling.
hansu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
halscope-ac-coupling.mp4
Further:
The offset was reset to zero when AC coupling was enabled.
This adds a data field to restore the previous offset value when disabling AC coupling.