XCCDF_POLICY: bound recursion on cyclic Profile @extends#2364
Open
edznux-dd wants to merge 1 commit into
Open
Conversation
A cyclic Profile @extends chain (A extends B extends A) recursed until the stack overflowed, both directly and indirectly via policy creation (_xccdf_policy_add_profile_selectors -> xccdf_policy_model_get_policy_by_id -> xccdf_policy_new -> back here). Track nesting in a file-static counter and abort past a sane depth. Also use NULL-safe comparison for the shadowing check. Note: a sibling unbounded-recursion fix for cyclic ARF catalog component-refs lives in src/DS/sds.c, which is on the memory-corruption branch because it is coupled with the use-after-free fix in the same function.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see #2361 for more context)
This is the 4th and last fix-PR of the series (the next one will be the fuzz harnesses)
This one feels more like hardening but it fixes a stack overflow issue on cyclic/deeply nested
@extendschain.I've set
XCCDF_POLICY_MAX_EXTENDS_DEPTHto 64, as an arbitrary value that seems conservative but can be changed if you have stronger opinion. (similar to #2363)