Skip to content

[RN][CI]: add safety net to prevent accidental LOCAL podspec versions#229

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions
May 29, 2026
Merged

[RN][CI]: add safety net to prevent accidental LOCAL podspec versions#229
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 28, 2026

What changes are you making?

Adds a new blocking CI step to ensure that the pod file doesn't point to local references
This would cause a podfile lock mismatch later in the flow, this is a fast fail with a clearer error message to avoid confusion and wasted time debugging

image.png


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 28, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.59% (316/345) 87.25% (178/204) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 28, 2026 12:33
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 28, 2026 12:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch 3 times, most recently from b6109af to 2dca0e6 Compare May 28, 2026 12:45
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns branch 2 times, most recently from 2c1d798 to 1f13cd8 Compare May 28, 2026 12:49
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch from 2dca0e6 to 165f743 Compare May 28, 2026 12:49
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as draft May 28, 2026 12:56
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch from 165f743 to acc13b7 Compare May 28, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch from acc13b7 to d3889c9 Compare May 28, 2026 13:31
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/05-28-fixremoveuse_local_sdkfromciruns to graphite-base/229 May 28, 2026 13:41
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/229 to kieran-osgood/release-workflow/rn-native-sdk-versions May 28, 2026 13:41
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 28, 2026 13:44
@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: add ci safety net for accidental LOCAL podspec versions [RN][CI]: add safety net to prevent accidental LOCAL podspec versions May 28, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/release-workflow/rn-native-sdk-versions branch from 023cd15 to 7dc139f Compare May 29, 2026 08:07
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch from d3889c9 to 4b49ab2 Compare May 29, 2026 08:07
Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 29, 2026

Merge activity

  • May 29, 10:31 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 29, 10:33 AM UTC: Graphite rebased this pull request as part of a merge.
  • May 29, 10:49 AM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/release-workflow/rn-native-sdk-versions to graphite-base/229 May 29, 2026 10:31
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/229 to main May 29, 2026 10:31
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch from 4b49ab2 to 63e5d29 Compare May 29, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify merged commit 5902bb4 into main May 29, 2026
20 checks passed
@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/05-28-feataddcisafetynetforaccidentallocalpodspecversions branch May 29, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants