Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how getUserRoles() determines the current user and loads preferences, aiming to fix login/redirect behavior for Data Browser by relying on ensureLoadedPreferences() instead of directly reading authSession.info / authn.currentUser() up front.
Changes:
- Simplifies
getUserRoles()by removing early-return checks againstauthSession.infoandauthn.currentUser(). - Switches to calling
ensureLoadedPreferences({})to derivemeand load the preferences file in a single flow. - Updates the thrown error when preferences cannot be loaded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix pref error undefined Prompt: fix preferencesFileError can be undefined copilot suggestion
bourgeoa
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the original login that is used by databrowser.
Reverse preferences fix. Can revisit later.
Tested locally.