Skip to content

chore: more robust membership tests#640

Merged
faretek1 merged 5 commits into
TimMcCool:mainfrom
Boss-1s:chore/#636
Jun 2, 2026
Merged

chore: more robust membership tests#640
faretek1 merged 5 commits into
TimMcCool:mainfrom
Boss-1s:chore/#636

Conversation

@Boss-1s
Copy link
Copy Markdown
Contributor

@Boss-1s Boss-1s commented Jun 2, 2026

Solves issue #636

Changes

  • Added lists for members and non-members, allowing check for both
  • Refactored membership test using any(getattr(...)) and all(getattr(...))

Commented out old test in case, if this passes i'll remove it

Tests

tests/test_memberships.py

Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Comment thread tests/test_memberships.py Outdated
Comment thread tests/test_memberships.py Outdated
Comment thread tests/test_memberships.py Outdated
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Signed-off-by: faretek1 <107722825+faretek1@users.noreply.github.com>
@faretek1
Copy link
Copy Markdown
Collaborator

faretek1 commented Jun 2, 2026

getattr is redundant because the values are guaranteed to be assigned in user.py

@faretek1 faretek1 merged commit f070509 into TimMcCool:main Jun 2, 2026
1 check passed
@Boss-1s Boss-1s deleted the chore/#636 branch June 2, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants