Rewrite line number computation in WSL#304
Open
jrmuizel wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@camillobruni review ping |
kmiller68
requested changes
Jun 3, 2026
Contributor
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Overall seems like a reasonable change. I do think most devs will end up using a regex for this so I'd mildly prefer keeping that. That's also how the original test was structured so all other things equal I'd prefer to keep it.
I know it's maybe(?) faster to use the manual loop due to Array allocation but we shouldn't be optimizing the benchmark itself.
Instead of computing the line number on demand, keep track of it as we
lex.
Previously, we ended up spending a quadratic amount of time computing
the line number because we'd do something like:
for every index:
count the number line breaks up to this index.
Fixes WebKit#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of computing the line number on demand, keep track of it as we lex.
Previously, we ended up spending a quadratic amount of time computing the line number because we'd do something like:
Fixes #298