Skip to content

temurin: add support for Alpine Linux#674

Open
gdams wants to merge 7 commits into
actions:mainfrom
gdams:alpine
Open

temurin: add support for Alpine Linux#674
gdams wants to merge 7 commits into
actions:mainfrom
gdams:alpine

Conversation

@gdams
Copy link
Copy Markdown
Contributor

@gdams gdams commented Aug 16, 2024

Description:
Adds support for Alpine Linux in setup-java for temurin

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@gdams gdams requested a review from a team as a code owner August 16, 2024 09:16
Comment thread .github/workflows/e2e-versions.yml Outdated
Copy link
Copy Markdown
Contributor

@skateball skateball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx

Copilot AI review requested due to automatic review settings June 3, 2026 15:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Alpine Linux detection/support for Temurin installs and extends CI to validate setup-java inside an Alpine container.

Changes:

  • Detect Alpine on linux by checking /etc/alpine-release and return alpine-linux as the platform key.
  • Update the compiled dist output to include the new platform detection logic.
  • Add a GitHub Actions job that runs setup-java + verification in an alpine container matrix.
Show a summary per file
File Description
src/distributions/temurin/installer.ts Adds linux platform branching to distinguish Alpine vs non-Alpine.
dist/setup/index.js Updates compiled distribution logic to match source change.
.github/workflows/e2e-versions.yml Adds containerized Alpine e2e job for Temurin/SapMachine across versions.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/3 changed files
  • Comments generated: 3

Comment thread .github/workflows/e2e-versions.yml
Comment thread .github/workflows/e2e-versions.yml
Comment thread .github/workflows/e2e-versions.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants