fix(@angular/build): exclude JSON imports from Vite dependency optimization#33292
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): exclude JSON imports from Vite dependency optimization#33292clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
…zation Importing `.json` files (such as package.json files from third-party packages) causes Vite's dependency optimizer to throw errors and warnings during `ng serve`, as Vite is unable to optimize non-JS/TS modules: `Cannot optimize dependency: @pkg-name/package.json, present in client 'optimizeDeps.include'` This fix filters out any implicit dependencies ending in `.json` in the `updateExternalMetadata` utility, preventing them from being included in Vite's `optimizeDeps.include` array. Closes angular#33280
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the external metadata utility in the Angular build tools to filter out .json files from both implicit server and implicit browser metadata arrays. The reviewer suggested a more robust check to handle import paths with query parameters (e.g., package.json?raw) by stripping query parameters before checking the file extension.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
clydin
added
target: patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing
.jsonfiles (such as package.json files from third-party packages) causes Vite's dependency optimizer to throw errors and warnings duringng serve, as Vite is unable to optimize non-JS/TS modules:Cannot optimize dependency: @pkg-name/package.json, present in client 'optimizeDeps.include'This fix filters out any implicit dependencies ending in
.jsonin theupdateExternalMetadatautility, preventing them from being included in Vite'soptimizeDeps.includearray.Closes #33280