Skip to content

test: add 20.0-project E2E test asset and update update tests to use it#33300

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:update-asset
Jun 3, 2026
Merged

test: add 20.0-project E2E test asset and update update tests to use it#33300
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:update-asset

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

Update e2e assets

@alan-agius4 alan-agius4 requested a review from clydin June 3, 2026 14:40
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 3, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the E2E test asset project from Angular v19 (nineteen-project) to Angular v20 (twenty-project), updating configuration files, dependencies, and test scripts accordingly. Feedback on the changes highlights two critical issues: first, provideBrowserGlobalErrorListeners is incorrectly imported from @angular/core instead of @angular/platform-browser, which will cause a compilation error; second, the index option is missing from the build configuration in angular.json, which will prevent the generation of the entry HTML file and cause E2E tests to fail.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/e2e/assets/20.0-project/src/app/app.config.ts
Comment thread tests/e2e/assets/20.0-project/angular.json
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 3, 2026
@alan-agius4 alan-agius4 merged commit 11a4438 into angular:main Jun 3, 2026
41 checks passed
@alan-agius4 alan-agius4 deleted the update-asset branch June 3, 2026 15:17
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants