fix(@angular/cli): validate registry option is a valid URL in ng add#33302
Open
clydin wants to merge 1 commit into
Open
fix(@angular/cli): validate registry option is a valid URL in ng add#33302clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces URL validation for the --registry option in the ng add command, throwing a CommandModuleError if the provided registry is not a valid URL, and adds a corresponding E2E test. The review feedback suggests enhancing this validation to ensure robust runtime type safety, specifically handling cases where registry might be parsed as an array or an empty string, and provides a code suggestion to address this.
Ensure that the --registry option passed to ng add is parsed as a valid absolute URL.
clydin
force-pushed
the
feat/ng-add-validate-registry
branch
from
91f449d to
4257663
Compare
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the --registry option passed to ng add is parsed as a valid absolute URL.