docs(cdk/dialog): improve dialog example contrast in dark themes#33334
Open
BHUVANSH855 wants to merge 1 commit into
Open
docs(cdk/dialog): improve dialog example contrast in dark themes#33334BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDK dialog examples use a white dialog background (
background: #fff) while inheriting text colors from the surrounding page theme.In dark themes on material.angular.dev, this results in dialog content being rendered with very low contrast, making headings, labels, and body text difficult to read.
This change adds a foreground text color to the affected dialog example hosts using
CanvasText, ensuring sufficient contrast against the existing white background while aligning with existing Angular Material usage of system colors.Affected examples:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Dialog content in several CDK dialog examples becomes difficult to read when viewed in dark themes because the dialog host uses a white background while text inherits colors intended for dark surfaces.
What is the new behavior?
The affected dialog examples explicitly use
CanvasTextfor foreground text, providing readable contrast against the white dialog background across themes.Does this PR introduce a breaking change?