Deduplicate sonar CI github workflow#13322
Draft
Pearl1594 wants to merge 3 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13322 +/- ##
============================================
- Coverage 18.10% 18.10% -0.01%
+ Complexity 16752 16749 -3
============================================
Files 6037 6037
Lines 542796 542796
Branches 66456 66456
============================================
- Hits 98291 98270 -21
- Misses 433460 433488 +28
+ Partials 11045 11038 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…p-sonar-workflows
Pearl1594
force-pushed
the
dedup-sonar-workflows
branch
from
bf3ecf9 to
584203c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the duplicated Sonar Quality Check GitHub Actions workflows into a single reusable workflow, intended to reduce maintenance overhead by keeping the PR and main-branch Sonar runs in sync.
Changes:
- Added a new reusable workflow (
sonar-reusable.yml) intended to perform checkout, environment setup, build/tests, and Sonar analysis. - Updated the PR-triggered workflow (
sonar-check.yml) to call the reusable workflow. - Updated the main-branch workflow (
main-sonar-check.yml) to call the reusable workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
.github/workflows/sonar-reusable.yml |
Introduces the shared Sonar build/test/scan workflow used by both PR and main runs. |
.github/workflows/sonar-check.yml |
Replaced inline Sonar job with a call to the reusable workflow for PRs. |
.github/workflows/main-sonar-check.yml |
Replaced inline Sonar job with a call to the reusable workflow for main pushes. |
Comments suppressed due to low confidence (1)
.github/workflows/sonar-reusable.yml:99
- The previous sonar workflows also uploaded the generated JaCoCo report to Codecov, but that step has been dropped in the reusable workflow. This changes CI behavior and removes coverage reporting for the backend (there are no other workflows uploading
client/target/site/jacoco-aggregate/jacoco.xml).
run: >
mvn -T$(nproc) -P quality -Dsimulator -Dnoredist clean install
org.sonarsource.scanner.maven:sonar-maven-plugin:sonar
-Dsonar.projectKey=apache_cloudstack
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+37
| secrets: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
Comment on lines
+39
to
+40
| secrets: | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR de-duplicates the sonar quality check workflows into a shared reusable workflow to avoid having to keep 2 files in sync.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?