Skip to content

fix(integ): replace AllowedTypes m5.* with ExcludedTypes for region compatibility#3937

Merged
vicheey merged 1 commit into
developfrom
fix/integ-test-instance-types
Jun 2, 2026
Merged

fix(integ): replace AllowedTypes m5.* with ExcludedTypes for region compatibility#3937
vicheey merged 1 commit into
developfrom
fix/integ-test-instance-types

Conversation

@vicheey
Copy link
Copy Markdown
Contributor

@vicheey vicheey commented Jun 2, 2026

Issue #, if available

N/A .

Description of changes

The m5 EC2 instances are not available in newer regions. See the list here: https://docs.aws.amazon.com/ec2/latest/instancetypes/ec2-instance-regions.html

This change is to makes the integration test region-agnostic while still exercising the InstanceRequirements configuration path.

Description of how you validated changes

Instead of specifying allowed types (which limits to specific families), use ExcludedTypes with a deny list so Lambda can select from any available instance type in the region.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ompatibility

m5 instances are not available in newer regions (TPE, BKK, KUL, QRO).
Instead of specifying allowed types (which limits to specific families),
use ExcludedTypes with a deny list (t2.*, t3.*) so LEGS can select from
any available instance type in the region.

This makes the integration test region-agnostic while still exercising
the InstanceRequirements configuration path.
@vicheey vicheey requested a review from a team as a code owner June 2, 2026 21:08
@vicheey vicheey merged commit 90ed07e into develop Jun 2, 2026
9 checks passed
@vicheey vicheey deleted the fix/integ-test-instance-types branch June 2, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants