fix(redis): preserve empty arrays in payload#15
Closed
rrmesquita wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for sending this, the bug is real and the direction makes sense. I think we need to take the fix a bit further before merging. This patch protects the I would rather make the invariant explicit. user job JSON/payload should stay opaque to Lua, and any Lua-side mutable metadata should be handled without re-encoding the full job. I'm going to take this on from our side because it touches a few Redis internals, but this PR helped identify the right problem. Thanks again for digging into it. |
RomainLanz
added a commit
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: Since I'm not too familiar with the codebase, this PR was AI assisted with Opus 4.8 high. Feel free to discard the PR — although I think the solution here makes sense.