Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changing
This is a move of the Python client to this new repo from its prior location at
python/superdb/in the super repo.Why
Two reasons I'm aware of:
pytestis appropriate in the Go-centric super repo, but that seems less of a concern in a separate Python-centric repo.pippulls inpyarrowwhich is a pretty big module, the client's ztests were reported as taking ~22 seconds or more when running local tests in the super repo.Details
This prepares an approach similar to what we've used for repos like Zui/Brimcap in the past: Tests will run automatically in Actions whenever a PR merges in super, and failure notifications will arrive via typical notifications like email/Slack. If a Dev is doing things they fear may break the client and they want to be proactive, the README describes how they can run the client tests locally, or they can enter their branch ref in the
repository_dispatchinput in the Actions UI.Next Steps
If this merges, there's four things I'd plan to do next:
superdb-pythonin therepo:matrix in super'snotify-downstream-merge.yamlActions Workflow so the tests will be triggered when super PRs mergepython/directory from the super repo (which will result in the ztests going away too)