Skip to content

feat(headless): add Popover primitive#8478

Open
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Open

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

@alexcarpenter alexcarpenter commented May 5, 2026 •
edited
Loading

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

# PR What it adds Base
1 #8474 Foundation (infra + hooks + utils + Dialog) main
2 #8475 Accordion ← #8474
3 #8476 Tabs ← #8475
4 #8477 cssVars + Tooltip ← #8476
5 #8478 Popover ← #8477
6 #8479 Select ← #8478
7 #8480 Menu ← #8479
8 #8481 Autocomplete + integration tests ← #8480

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented May 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Error Error Jun 3, 2026 5:33pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 032b0f0 to 24adffa Compare May 5, 2026 15:26
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752 Compare May 5, 2026 15:26
@alexcarpenter alexcarpenter mentioned this pull request May 5, 2026
Open
3 tasks
This was referenced May 5, 2026
Open
Open
Open
Open
Open
Open
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810 Compare May 5, 2026 15:39
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 24adffa to 38c58e6 Compare May 5, 2026 15:39
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 38c58e6 to 8136289 Compare May 5, 2026 15:49
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95 Compare May 5, 2026 15:49
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6f Compare May 5, 2026 18:38
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 8136289 to 3b5f83f Compare May 5, 2026 18:38
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8 Compare June 3, 2026 17:09
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from c190d6f to db49302 Compare June 3, 2026 17:09
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbd Compare June 3, 2026 17:19
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from db49302 to a01dab9 Compare June 3, 2026 17:19
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787 Compare June 3, 2026 17:23
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3 Compare June 3, 2026 17:23
alexcarpenter and others added 8 commits June 3, 2026 13:32
@alexcarpenter @claude
feat(headless): add package foundation with Dialog primitive
b687e0f 
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:

- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
  mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter @claude
feat(headless): add package foundation with Dialog primitive
e949e7a 
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:

- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
  mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter @claude
feat(headless): add package foundation with Dialog primitive
d5008d6 
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:

- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
  mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter @claude
feat(headless): add package foundation with Dialog primitive
78c8d93 
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:

- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
  mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter
feat(headless): add Popover primitive
77075dc
@alexcarpenter
refactor(headless): split Popover into per-file parts for tree-shaking
ce176cb
@alexcarpenter
docs(headless): update Popover README for .Root usage
c5c5da7
@alexcarpenter
fix(headless): update Popover context error message for .Root usage
9cc0903
@alexcarpenter alexcarpenter force-pushed the carp/headless-tooltip branch from 64c21e3 to da71e49 Compare June 3, 2026 17:33
@alexcarpenter alexcarpenter force-pushed the carp/headless-popover branch from 7bc3787 to 9cc0903 Compare June 3, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter