Codebridge: fix for file name validation#73004
Open
molly-moen wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
converting to draft, found another gap in the validation |
molly-moen
commented
Jun 2, 2026
| ## To Dos | ||
| - **Validation** (`get_validations` override on `Javalab`, | ||
| `JavaValidator`, `JavaValidationTracker`, test-result handling). | ||
| - **File name validation** there are no checks for invalid file names yet. |
Contributor
Author
There was a problem hiding this comment.
When doing the java lab conversion I thought this was a specific issue to Java Lab on lab2 but it turned out it was more universal than that!
molly-moen
changed the title
hannahbergam
approved these changes
Jun 3, 2026
Contributor
hannahbergam
left a comment
hannahbergam
left a comment
There was a problem hiding this comment.
Thanks for adding the tests! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we moved to the version of the file creation modal that uses a dropdown for file extensions we introduced two bugs:
my.main.pythonwould pass validation when it wouldn't previously.This PR fixes these issues, present in Python Lab, Web Lab 2, and Java Lab on lab2.
Before
Screen.Recording.2026-06-02.at.2.36.37.PM.mov
After
Screen.Recording.2026-06-02.at.2.37.11.PM.mov
Testing story
Tested locally and added unit tests.