Skip to content

feat: add pagination and test cases for AM package#209

Open
naman-contentstack wants to merge 1 commit into
v2-devfrom
feat/DX-8625
Open

feat: add pagination and test cases for AM package#209
naman-contentstack wants to merge 1 commit into
v2-devfrom
feat/DX-8625

Conversation

@naman-contentstack
Copy link
Copy Markdown
Contributor

Summary

  • Previously, listSpaces, getWorkspaceAssets, and getWorkspaceFolders issued a
    single API request, silently truncating results for orgs with large numbers of spaces
    or assets.
  • Introduces a fetchAllPages helper in CSAssetsAdapter that fetches the first page
    to read the total count, computes remaining skip offsets, and issues those requests
    in controlled-concurrency batches — returning the full merged result set.
  • Exposes two new tunables — pageSize (default 100) and fetchConcurrency
    (default 5) — threaded through ExportContext, ExportSpaces, ExportAssets,
    ImportSpaces, and ImportSetupAssetMappers.

Changes

  • CSAssetsAdapter: added private fetchAllPages; updated listSpaces,
    getWorkspaceAssets, getWorkspaceFolders to use it
  • constants: added FALLBACK_AM_API_PAGE_SIZE and FALLBACK_AM_API_FETCH_CONCURRENCY
  • ExportContext / AssetManagementExportOptions: added pageSize, fetchConcurrency
  • CSAssetsExportAdapter: added apiPageSize and apiFetchConcurrency getters
  • ExportSpaces, ExportAssets, ImportSpaces, ImportSetupAssetMappers: wired
    new params through to all list calls

@naman-contentstack naman-contentstack self-assigned this Jun 4, 2026
@naman-contentstack naman-contentstack requested a review from a team as a code owner June 4, 2026 12:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 1 25 ✅ Passed
🟡 Medium Severity 0 2 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

⚠️ Warning: The following vulnerabilities have exceeded their SLA thresholds (days since publication).

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 1 90 / 365 days ⚠️ Warning
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 1
  • Medium without fixes: 2
  • Low without fixes: 0

⚠️ BUILD PASSED WITH WARNINGS - SLA breaches detected for issues without available fixes

Consider reviewing these vulnerabilities when fixes become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant