Use inquirer prompt to select response mode#172
Merged
Conversation
feat: use inquirer select prompt for response mode instead of text input
venky0195
approved these changes
Jun 3, 2026
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
dhruv-parekh-cs
approved these changes
Jun 3, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves the interactive CLI UX by switching the “response mode” prompt from free-text input to an Inquirer list selection, ensuring users can only choose supported modes (buffered or streaming).
Changes:
- Replaced
input+ manual validation/normalization with alistprompt for response mode selection in both GitHub and FileUpload adapters. - Simplified streaming enablement logic to a direct equality check against the selected value.
- Updated adapter unit tests to assert the new prompt shape (
type: 'list',choices) and adjusted response-mode mapping cases accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/adapters/github.ts | Switches response mode prompt to a list selection and simplifies mapping to isStreamingEnabled. |
| src/adapters/github.test.ts | Updates tests to expect the list prompt and its choices; adjusts mapping/behavior assertions. |
| src/adapters/file-upload.ts | Switches response mode prompt to a list selection and simplifies mapping to isStreamingEnabled. |
| src/adapters/file-upload.test.ts | Updates tests to expect the list prompt and its choices; adjusts mapping/behavior assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: use inquirer select prompt for response mode instead of text input