guides: update python & add files component#25206
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dvdksn
left a comment
There was a problem hiding this comment.
Reviewed the full guide — looks good, solid improvement. The inline sample + files component read well, naming and ports are consistent, and the multi-stage DHI Dockerfile is sound. Two notes on the scaffold path in the files shortcode, inline below: the heredoc delimiter one is worth fixing; the BOM one is a non-blocking follow-up.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
This PR is a substantial, high-quality rework of the Python guide. The new file browser/scaffold component is well-implemented, the DHI-only approach is a good simplification, and the new supply chain topic is a valuable addition. Four issues found in the changed content.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR rewrites the Python guides series to use Docker Hardened Images (DHI) and introduces a new {{< files >}}/{{< file >}} shortcode pair. The overall direction is solid, but there are three high-severity factual errors in the newly added content that should be fixed before merging.
High severity (3): fabricated version number, placeholder SHA-256 digest, and a typo in the develop.md overview.
Medium severity (2): an absolute claim that pre-commit hooks bypass prevention is inaccurate, and the example database password lacks a production-use warning.
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
Description
Updated Python guide
https://deploy-preview-25206--docsdocker.netlify.app/guides/python/
Related issues or tickets
ENGDOCS-3308
Reviews