change(instance-id): Remove deprecated Instance ID service#3166
Open
jonathanedey wants to merge 2 commits into
Open
change(instance-id): Remove deprecated Instance ID service#3166jonathanedey wants to merge 2 commits into
jonathanedey wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated instance-id service and all of its associated files, exports, and tests across the codebase. The review feedback highlights opportunities to clean up minor formatting issues in src/app/firebase-namespace.ts, such as an extra space and consecutive empty lines, as well as to remove duplicate imports in test/unit/index.spec.ts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request completely removes the deprecated Instance ID (IID) service and all its associated exports, namespaces, and test suites. Developers should use the Firebase Installations service (
installations()) instead for all instance management.