Skip to content

ci: Raise minimum supported aiomysql version and update text matrix #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-alderman-webb wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ci: Raise minimum supported aiomysql version and update text matrix #6496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b6c5a2
ci: Update text matrix with aiomysql
alexander-alderman-webb Jun 3, 2026
482b3bb
.
alexander-alderman-webb Jun 3, 2026
469f15c
.
alexander-alderman-webb Jun 5, 2026
9091a35
bump minimum version
alexander-alderman-webb Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/test-integrations-dbs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,25 @@ jobs:
# Maps tcp port 5432 on service container to the host
ports:
- 5432:5432
mysql:
image: mysql
env:
MYSQL_ROOT_PASSWORD: sentry
options: >-
--health-cmd "mysqladmin ping -h localhost"
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
- 3306:3306
env:
# 3.6/3.7 run in the python:X.Y container; tell uv to use that system Python.
TOX_UV_PYTHON_PREFERENCE: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'only-system' || 'managed' }}
SENTRY_PYTHON_TEST_POSTGRES_HOST: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'postgres' || 'localhost' }}
SENTRY_PYTHON_TEST_POSTGRES_USER: postgres
SENTRY_PYTHON_TEST_POSTGRES_PASSWORD: sentry
SENTRY_PYTHON_TEST_MYSQL_USER: root
SENTRY_PYTHON_TEST_MYSQL_PASSWORD: sentry
container: ${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}
Comment thread
alexander-alderman-webb marked this conversation as resolved.
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand All @@ -56,6 +69,10 @@ jobs:
- name: Setup Test Env
run: |
uv sync
- name: Test aiomysql
run: |
set -x # print commands that are executed
./scripts/runtox.sh "py${{ matrix.python-version }}-aiomysql"
- name: Test asyncpg
run: |
set -x # print commands that are executed
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-integrations-web-1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,13 @@ jobs:
image: postgres
env:
POSTGRES_PASSWORD: sentry
# Set health checks to wait until postgres has started
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
# Maps tcp port 5432 on service container to the host
ports:
- 5432:5432
env:
Expand Down
112 changes: 57 additions & 55 deletions scripts/populate_tox/package_dependencies.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

29 changes: 15 additions & 14 deletions scripts/populate_tox/releases.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions scripts/populate_tox/tox.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ passenv =
SENTRY_PYTHON_TEST_POSTGRES_PASSWORD
SENTRY_PYTHON_TEST_POSTGRES_NAME
SENTRY_PYTHON_TEST_REDIS_HOST
SENTRY_PYTHON_TEST_MYSQL_USER
SENTRY_PYTHON_TEST_MYSQL_PASSWORD
TESTPATH

basepython =
Expand Down
3 changes: 0 additions & 3 deletions scripts/split_tox_gh_actions/templates/test_group.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
image: mysql
env:
MYSQL_ROOT_PASSWORD: sentry
MYSQL_DATABASE: test_db
options: >-
--health-cmd "mysqladmin ping -h localhost"
--health-interval 10s
Expand All @@ -68,10 +67,8 @@
SENTRY_PYTHON_TEST_REDIS_HOST: {% raw %}${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'redis' || 'localhost' }}{% endraw %}
{% endif %}
{% if needs_mysql %}
SENTRY_PYTHON_TEST_MYSQL_HOST: {% raw %}${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && 'mysql' || 'localhost' }}{% endraw %}
SENTRY_PYTHON_TEST_MYSQL_USER: root
SENTRY_PYTHON_TEST_MYSQL_PASSWORD: sentry
SENTRY_PYTHON_TEST_MYSQL_DB: test_db
{% endif %}
container: {% raw %}${{ (matrix.python-version == '3.6' || matrix.python-version == '3.7') && format('python:{0}', matrix.python-version) || null }}{% endraw %}
steps:
Expand Down
2 changes: 1 addition & 1 deletion sentry_sdk/integrations/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def iter_default_integrations(

_MIN_VERSIONS = {
"aiohttp": (3, 4),
"aiomysql": (0, 1, 1),
"aiomysql": (0, 3, 0),
"anthropic": (0, 16),
"ariadne": (0, 20),
"arq": (0, 23),
Expand Down
Loading
Loading