fix(explore): Action menus not supporting numbers or booleans#116706
Open
nsdeschenes wants to merge 6 commits into
Open
fix(explore): Action menus not supporting numbers or booleans#116706nsdeschenes wants to merge 6 commits into
nsdeschenes wants to merge 6 commits into
Conversation
Preserve the `type` field from `TraceItemResponseAttribute` in the internal `Attribute` interface so downstream consumers can distinguish number/boolean attributes from strings when building actions.
When actioning number/float attributes, wrap the key as `tags[key,number]`; for booleans, `tags[key,boolean]`. This applies to the trace drawer, metric, and log attribute tree actions so the query builder receives properly typed filter keys.
Fall back to `classifyTagKey` when a key isn't in the pre-fetched tags collection. This allows `tags[key,number]` keys to be recognized as numeric fields, enabling comparison operators (>, <, >=, <=) in the query builder.
github-actions
Bot
added
the
Scope: Frontend
`decodeColumnOrder` now uses `classifyTagKey` to set the column type for `tags[key,number]` and `tags[key,boolean]` fields. This ensures the cell action menu shows numeric operators (greater/less than) for number columns instead of string-only actions (add/exclude).
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
changed the title
Known predefined fields like http.status_code should not be wrapped in tags[key,type] syntax, since downstream lookups via getFieldDefinition and field inclusion checks expect the canonical key name. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Contributor
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 32d240f. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
getFieldDefinition defaulted to 'event' type, missing span-specific fields like http.decoded_response_content_length and gen_ai.cost.total_tokens. These known fields were incorrectly wrapped in tags[key,number] syntax, breaking filter actions in the trace drawer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags[key,number],tags[key,boolean]) instead of raw attribute names when adding filters fornumber/float/boolean attributes
classifyTagKeyfallback, so numeric operators (>, <, >=, <=) are available even when the attribute isn't in the pre-fetchedtags collection
tags[key,number]columns instead of string-only "add to filter"Closes EXP-980