Update GitHub Actions workflow for NPM publishing#210
Open
gracepark wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to pin action versions by commit SHA, bump the Node.js version used during publishing, and migrate away from using an npm token in the publish step (per the PR’s OIDC migration intent).
Changes:
- Pin
actions/checkoutandactions/setup-nodeto specific commit SHAs (with version comments). - Bump the workflow Node.js version from 22 to 24.
- Remove
NODE_AUTH_TOKENusage duringnpm publish --provenance.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yml |
Pins action dependencies, updates Node version, and changes npm publishing authentication flow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
| - run: npm whoami; npm --ignore-scripts publish --provenance | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}} | ||
| - run: npm --ignore-scripts publish --provenance |
lindseywild
approved these changes
Jun 3, 2026
Contributor
|
I think this was superseded by #209, which made similar changes. Related discussion: #209 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309#issuecomment-4608163612
OIDC migration