Skip to content

fix(core/patch-harness): prefer project virtualenv validators#562

Open
cbusillo wants to merge 1 commit into
just-every:mainfrom
cbusillo:code-python-runtime-validation
Open

fix(core/patch-harness): prefer project virtualenv validators#562
cbusillo wants to merge 1 commit into
just-every:mainfrom
cbusillo:code-python-runtime-validation

Conversation

@cbusillo
Copy link
Copy Markdown

Summary

  • teach the patch harness to look for mypy and pyright in the nearest project .venv or venv before falling back to PATH
  • carry the matching PATH and VIRTUAL_ENV into the validator process when a local env is found
  • add coverage for search order and fallback behavior

Why

Auto-validation was using whatever global mypy or pyright happened to be on PATH. In Python repos that meant the harness could miss the project interpreter, miss installed stubs, or run a different tool version than the repo expects. This keeps patch-harness validation lined up with the repo's own virtualenv.

Testing

  • ./build-fast.sh
  • cargo test -p code-core patch_harness

@cbusillo cbusillo marked this pull request as ready for review March 17, 2026 01:59
@zemaj
Copy link
Copy Markdown

zemaj commented Jun 3, 2026

Codex PR triage, 2026-06-03:

Please update onto current main, rerun ./build-fast.sh, and make the fallback test platform-safe, for example by gating sh with #[cfg(unix)] or using a neutral fixture.

@cbusillo
Copy link
Copy Markdown
Author

cbusillo commented Jun 3, 2026

Hey @zemaj, since you were busy and not checking out PRs, I've diverged more towards Codex CLI (app server was important to me) I have a ton of fixes and features, but I fear we are too incompatible now. Would you like me to close all my open PRs to get them out of your way or leave them open so you can take ideas?

I'm guessing you just build a feature to auto review PRs :)

@zemaj
Copy link
Copy Markdown

zemaj commented Jun 3, 2026

Hah yeah sorry @cbusillo, running a bulk multi-agent plugin and testing it on all the outstanding PRs. Didn't expect it to send the actual triage messages. I use Every Code on the terminal but for daily use I've mostly moved towards the Codex app too since I like the mac app version.

Here's the multi-agent system if you're interested and using a Codex compatible fork - closely mirrors how the new Claude Ultracode works but as a Codex plugin https://github.com/just-every/plugin-ultracode

@cbusillo
Copy link
Copy Markdown
Author

cbusillo commented Jun 3, 2026

Thanks, I'm going to close my PRs, but thanks for the tip.

Just to be clear, you are moving away from Every Code? If so, I guess I am glad I started aligning back with Codex CLI recently! I'll be looking at your new repo and figuring out out my options. I layered a lot on top of Every Code, so I'm not sure whats right for me yet.

Thank you for all the amazing work. I learned a lot from you!

@zemaj
Copy link
Copy Markdown

zemaj commented Jun 3, 2026

I still use Every Code a lot (particularly when travelling). But I do a lot of front-end work and the Codex app with the inbuilt browser is amazing for that, so it's my daily driver now. The plugin system is so powerful now that it's possible to build features that I could only have done before in Every Code, so I've been experimenting with that as well.

However, I will maintain Every Code indefinitely. Even if it's just keeping it in sync with codex as long as is possible and major bug fixes. I find it really useful to keep up-to-date with the changes to the CLI.

@cbusillo
Copy link
Copy Markdown
Author

cbusillo commented Jun 3, 2026

Before Codex desktop came out I built my Discord UI and a GitHub integration, I'm trying to figure out where I want that to land. I'm going to follow your lead and check out Codex's plugin system. I haven't used it yet. I think the single most powerful aspect of your harness is the auto review. I leave that turned on and get such good results.

I agree about Codex desktop and its browser, so useful. What I have done a few times is get Every Code to make a one shot UI prompt, give it to Claude Design, take its first draft feed to to Every Code, and then when UI tweaking needs to happen, feed it to Codex desktop. They all write and wait for each other's handoff files.

Anyway, I will take all that I have learn here, and keep working, thank you sooo much for all you've done. I think I'm going to see what we can do with Codex and Plugins with Every Code's influence. And of course check out your plugins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants