feat: add lazy load eager eviction#1574
Draft
shikaku2 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from draft PR #1573: #1573
Summary
Adds a
-ll/--lazy-loadflag for lazy load/eager evict model execution. The goal is to make larger image models practical on limited VRAM systems by loading model tensors through mmap and dropping already-used component pages after each pipeline stage.This PR intentionally contains only the runtime lazy-load/eager-evict path. The conversion/RMSE/AIO work from #1573 is not included here.
How it works
--lazy-loadis set.free_params_immediately, so component backend buffers are released after use.evict_memory()helper inutil.cpp.MADV_DONTNEEDbehindSD_MMAP_FLAGS=dontneed; without that flag, the helper is a no-op.--lazy-loadto avoid very large single VAE decode allocations. On my Vulkan setup, SD3.5 VAE decode at 1024x1024 would otherwise hit a large VkBuffer allocation that exceeds common VulkanmaxMemoryAllocationSizelimits.Testing
cmake --build build -j16.git diff --checkpasses.Notes
This addresses the lazy-loading-specific review feedback from #1573 by keeping platform-dependent eviction code in
util.cpp, makingMADV_DONTNEEDopt-in throughSD_MMAP_FLAGS=dontneed, and calling eviction for regular mmap-backed load paths too.