fix(macos): respect disabled state for menu items#46
Merged
Conversation
- Set autoenablesItems=NO on NSMenu so explicit setEnabled: calls are not overridden by AppKit's auto-validation. - Add isEnabled check in menuItemClicked: as an extra safety net to ignore clicks on disabled items. - Implement menu:validateMenuItem: on NSMenuDelegateImpl to return the item's actual isEnabled state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
MenuItem::SetEnabled(false)on macOS, the disabled menu item remains clickable. This happens because:NSMenuhasautoenablesItemsenabled by default, which overrides explicitsetEnabled:calls during menu validation.menuItemClicked:handler did not check the item's enabled state.Changes
autoenablesItems = NOonNSMenuso that explicitly set enabled states are always respected.isEnabledcheck inmenuItemClicked:callback as an extra safety net — if AppKit still sends the action for a disabled item, the handler ignores it.menu:validateMenuItem:inNSMenuDelegateImplto return the item's actualisEnabledstate.Testing
Verified that a disabled menu item now appears grayed out and does not fire
MenuItemClickedEventwhen clicked.