fix(upnp): panic with "mapping should exist"#6459
Open
ackintosh wants to merge 13 commits into
Open
Conversation
dariusc93
reviewed
Jun 1, 2026
Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com>
1093f89 to
8fc9b37
Compare
ackintosh
commented
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #6377
This PR splits the
mappingsfield intomappings,add_requests, andremove_requeststo manage port mappings and in-flight request tracking in separate data structures.The
network_interface_changeandlistener_with_multiple_addressestests added in this PR reproduce the issue described in #6377, and both now pass after the fix.AI Assistance Disclosure
Tools used (required — write
noneif no AI was used): Claude CodeAttestation (required):
Notes & open questions
#6459 (comment)
Change checklist