fix: use sys.executable instead of hardcoded 'python' for subprocess calls#551
Open
desmonna wants to merge 1 commit into
Open
fix: use sys.executable instead of hardcoded 'python' for subprocess calls#551desmonna wants to merge 1 commit into
desmonna wants to merge 1 commit into
Conversation
…calls On Windows with multiple Python installations, hardcoded 'python' resolves to the system default (via PATH) rather than the active venv interpreter. This causes subprocess-spawned children to miss venv-installed packages. Replace all 10 occurrences of ["python", ...] with [sys.executable, ...]: - ga_cli/cli.py: 7 command entries (gui, configure, hub, tui, tui2, cli, launch) - memory/checklist_helper.py: 3 subprocess.Popen calls (bbs, worker, master)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows with multiple Python installations (e.g. system Python + venv),
hardcoded
"python"in subprocess calls resolves to the system defaultvia PATH, not the active venv interpreter. This causes child processes to
miss all venv-installed packages (PyQt5, Textual, pywebview, etc.), resulting
in
ModuleNotFoundErroron startup.Fix
Replace all 10 occurrences of
["python", ...]with[sys.executable, ...].sys.executablereturns the absolute path of the currently running Pythoninterpreter, guaranteeing child processes inherit the same venv environment.
This is the officially recommended approach for cross-platform compatibility.
Changes
ga_cli/cli.pymemory/checklist_helper.pyTesting
ga gui,ga tui,ga clilaunch correctly under venvFixes #501