fix(sentry)!: Fix Sentry -> Plane config schema.#282
Conversation
BREAKING CHANGE: More like breaking fix, but the old schema before this would not work at all, since all of these have to be prefxied with `/silo`. I have found this out manually the hard way when I spent 17 hours in a Discord VC with 10 other people trying to figure out why the integration would not work.
|
@Asynchronite is attempting to deploy a commit to the Marketing at Plane Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
More reviews will be available in 53 minutes and 54 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Sentry integration documentation is updated to reflect Plane's self-hosted architecture by systematically repointing all API endpoint URIs from standard ChangesSentry Silo API Routes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
If y'all had anyone complain about Sentry issues, try giving them this fix and seeing if it fixes it. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/self-hosting/govern/integrations/sentry.md (1)
154-154:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Inconsistent project URI missing
/siloprefix.Line 154 still uses
/api/sentry/projectswhile line 209 correctly uses/silo/api/sentry/projects. According to the PR description, all endpoints must be prefixed with/silo. This inconsistency will break project selection when creating issues from Sentry.🔧 Proposed fix
{ - "uri": "/api/sentry/projects", + "uri": "/silo/api/sentry/projects", "name": "project_id", "type": "select",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/self-hosting/govern/integrations/sentry.md` at line 154, The documented Sentry project endpoint is missing the required /silo prefix; update the "uri" value that currently reads "/api/sentry/projects" to "/silo/api/sentry/projects" so it matches the other occurrences (e.g., the entry that correctly uses "/silo/api/sentry/projects"); ensure any other identical "uri" occurrences in this doc are also updated to include the /silo prefix to avoid mismatch when creating Sentry issues.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/self-hosting/govern/integrations/sentry.md`:
- Line 154: The documented Sentry project endpoint is missing the required /silo
prefix; update the "uri" value that currently reads "/api/sentry/projects" to
"/silo/api/sentry/projects" so it matches the other occurrences (e.g., the entry
that correctly uses "/silo/api/sentry/projects"); ensure any other identical
"uri" occurrences in this doc are also updated to include the /silo prefix to
avoid mismatch when creating Sentry issues.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c974b3c7-63ce-404b-a90c-7c269273c43b
📒 Files selected for processing (1)
docs/self-hosting/govern/integrations/sentry.md
Fixed |
1 participant
Description
BREAKING CHANGE: More like breaking fix, but the old schema before this would not work at all, since all of these have to be prefxied with
/silo. I have found this out manually the hard way when I spent 17 hours in a Discord VC with 10 other people trying to figure out why the integration would not work.Type of Change
Screenshots and Media (if applicable)
Before fix:
Post fix:
Test Scenarios
Tested with
pnpm run dev:References
None that I could find.
Summary by CodeRabbit