ci: execute workflow_by_code.ipynb in GitHub Actions (closes #1278)#2241
Open
anupddas wants to merge 2 commits into
Open
ci: execute workflow_by_code.ipynb in GitHub Actions (closes #1278)#2241anupddas wants to merge 2 commits into
anupddas wants to merge 2 commits into
Conversation
ci: add GitHub Actions job to execute workflow_by_code.ipynb
Renamed 'lint' target to 'install-lint' to avoid collision with the lint check-runner target. Added new 'nbmake' target for executing notebook tests.
Author
|
@microsoft-github-policy-service agree |
CHGY003
approved these changes
Jun 1, 2026
CHGY003
approved these changes
Jun 1, 2026
Author
You're welcome! Glad I could help fix the issue. Let me know if any changes are needed once the workflows finish running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1278
Adds a dedicated GitHub Actions workflow that executes
examples/workflow_by_code.ipynbend-to-end on every push/PR that touches the notebook or core qlib code.
Changes
.github/workflows/test_notebook.yml— new workflow using pytest-nbmakeMakefile— newnbmaketarget (mirrors CI, runnable locally viamake nbmake)examples/workflow_by_code.ipynb— add CI environment detection celltests/test_workflow_notebook.py— fast structural tests for the notebook.pre-commit-config.yaml— add nbstripout hook to keep outputs strippedHow to test locally
Checklist
test_qlib_from_source.ymlpatterns