.Net: Fix #14021: Prune unannotated POCO properties from Redis JSON payloads

[summitbaj]

Motivation and Context

Resolves #14021

Currently, when the .NET RedisJsonCollection upserts data, the RedisJsonMapper serializes the provided POCO into a JsonNode using JsonSerializerOptions. Because JsonSerializer serializes all public properties by default, any POCO properties not uniquely annotated with [VectorStoreData] or [VectorStoreVector] inadvertently leak into the serialized JSON payload and are sent to Redis.

Description

This PR addresses the serialization leak by implementing an explicit allow-list pruning phase within the mapper:

1. Pre-computed Allow-List: An _allowedStorageNames HashSet is populated inside RedisJsonMapper using the StorageName of all annotated DataProperties and VectorProperties from the active schema.
2. Payload Pruning: During MapFromDataToStorageModel, after JsonSerializer.SerializeToNode() completes, we evaluate the top-level keys. Any unannotated keys absent from the allow-list are dynamically scrubbed via jsonNode.Remove().

By serializing the full POCO first and conditionally dropping keys, we safely preserve all of the user's custom System.Text.Json settings (naming policies, custom converters, etc.) without mutating their global resolver caching or forcing them to pollute their POCOs with global [JsonIgnore] attributes.

Testing of the Changes

• I updated RedisJsonCollectionTests.cs to remove the hardcoded notAnnotated / NotAnnotated mock returns, as well as the original // TODO comments documenting the JSON leak.
• I added Assert.False(jsonObject!.ContainsKey("NotAnnotated")) to RedisJsonMapperTests to guarantee isolated test coverage against future regressions mapping MultiPropsModel.
• Validated locally using .NET 10 SDK (dotnet test returned 109/109 success).

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR ensures Redis JSON payloads only include properties that are part of the vector data model, excluding unannotated properties like NotAnnotated, and updates tests accordingly.

Changes:

• Filter out non-model properties during MapFromDataToStorageModel in RedisJsonMapper.
• Add assertions in mapper unit tests to ensure unannotated properties are excluded.
• Update Redis JSON collection tests’ expected JSON payloads to omit NotAnnotated and remove the related TODO.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
dotnet/src/VectorData/Redis/RedisJsonMapper.cs	Filters serialized JSON to retain only allowed model-backed storage property names.
dotnet/test/VectorData/Redis.UnitTests/RedisJsonMapperTests.cs	Adds assertions verifying unannotated properties are not included.
dotnet/test/VectorData/Redis.UnitTests/RedisJsonCollectionTests.cs	Updates expected JSON strings to exclude NotAnnotated and removes the outdated TODO.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Automated Code Review

Reviewers: 4 | Confidence: 93% | Result: All clear

Reviewed: Correctness, Security Reliability, Test Coverage, Design Approach

---

Automated review by summitbaj's agents

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.