Browser: better tracking of per-window trust#319601
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines how the Electron main process tracks “trusted file roots” for integrated browser views on a per-window basis, aiming to keep the global trusted-roots set in sync as windows come and go.
Changes:
- Replace a global
windowsMainService.onDidDestroyWindowlistener with per-window lifecycle subscriptions created on demand when a window reports trusted roots. - Track and dispose per-window close subscriptions via a
DisposableMap<number>. - Recompute the global trusted file roots set whenever per-window roots change or a tracked window closes.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/browserView/electron-main/browserViewMainService.ts | Switches trusted-roots cleanup from a global window-destroy listener to per-window lifecycle subscriptions and disposal tracking. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bryanchen-d
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.