fix: avoid dropped errors when transport is closed or uninitialized#995
Open
chemicL wants to merge 2 commits into
Open
fix: avoid dropped errors when transport is closed or uninitialized#995chemicL wants to merge 2 commits into
chemicL wants to merge 2 commits into
Conversation
Signed-off-by: Dariusz Jędrzejczyk <2554306+chemicL@users.noreply.github.com>
Signed-off-by: Dariusz Jędrzejczyk <2554306+chemicL@users.noreply.github.com>
Kehrlann
reviewed
Jun 3, 2026
| @Test | ||
| void testCloseInitialized() { | ||
| var transport = HttpClientStreamableHttpTransport.builder(host).build(); | ||
| // transport.connect(Function.identity()).block(); |
Contributor
There was a problem hiding this comment.
How come we don't need to call "connect" anymore?
If we are not "connect"-ed, shouldn't sendMessage error rather than complete?
| import io.modelcontextprotocol.spec.McpTransportSessionNotFoundException; | ||
| import io.modelcontextprotocol.spec.McpTransportStream; | ||
| import io.modelcontextprotocol.spec.ProtocolVersions; | ||
| import io.modelcontextprotocol.spec.*; |
Contributor
There was a problem hiding this comment.
nit - we typically don't do star imports.
| }) | ||
| .retryWhen(authorizationErrorRetrySpec()) | ||
| .flatMap(jsonrpcMessage -> this.handler.get().apply(Mono.just(jsonrpcMessage))) | ||
| .flatMap(jsonrpcMessage -> requestHandler.apply(Mono.just(jsonrpcMessage))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also avoid logging peer disconnect at warn level.