zend_ini.c: fix zend_ini_bool_literal() with unknown INI setting#22209
Merged
Conversation
TimWolla
reviewed
Jun 2, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
I'm not sure I like this, because zend_ini_parse_bool is also used in other contexts than zend_ini_str() where crashing for NULL inputs might be the right thing to do.
It might be cleaner to have a dedicated bool zend_ini_bool(const char *name, size_t name_length, bool orig) that is wrapped by zend_ini_bool_literal() and then contains the delegate to zend_ini_str + NULL check zend_ini_parse_bool.
But I don't have a strong opinion on this. The change definitely works.
Member
Author
|
Considering every other ones of the API's returns a default value, I think this is fine. If one want's to check for existence the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes GH-22208