Labels for numeric scales compare on datum.value#464
Open
teunbrand wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hmm... I'm quite sure there was a reason for this because Vega-Lite is vegalite... It has been a repeated issue to get break labelling to work correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #461.
The issue is that
datum.label == '2000' ? '2000'didn't work because the label was actually '2,000' instead of '2000'.In this PR, we compare
datum.valueto unquoted numbers instead.Most of it is plumbing to get the right information to the right place.