gh-126845 email parsedate_to_datetime 3 digit year fix#150864
gh-126845 email parsedate_to_datetime 3 digit year fix#150864bitdancer wants to merge 15 commits into
Conversation
| @@ -0,0 +1,7 @@ | |||
| Fixed the :mod:`email` module parsing of three digit dates to | |||
| conform to :rfc:`5322`: three digit dates were previously | |||
There was a problem hiding this comment.
This file has CRLF line endings, resulting in the CI failure.
There was a problem hiding this comment.
Is that because I used the web editor? Is github really that broken?
Fixed.
There was a problem hiding this comment.
Is that because I used the web editor? Is github really that broken?
Yep :'-(
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I understand the rationale. This is to handle output of non-Y2000-compatible software.
| # between 0 and 68 are to be treated as 2000s dates. | ||
| # (https://datatracker.ietf.org/doc/html/rfc5322#section-4.3) | ||
| if yy < 1000: | ||
| if yy > 68: |
There was a problem hiding this comment.
The threshold is 49 according to RFC 5322.
There was a problem hiding this comment.
See my comment on the issue for discussion on this.
| if yy < 1000: | ||
| if yy > 68: | ||
| yy += 1900 | ||
| # The year is between 2000 and 2068 (inclusive). |
There was a problem hiding this comment.
The comment was correct. It should be updated after changing the threshold.
There was a problem hiding this comment.
I feel like the two comments on the if/else are redundant after the change to the block comment above it, but if you prefer to keep those two comments I'll add them back.
| if yy < 1000: | ||
| if yy > 68: | ||
| yy += 1900 | ||
| # The year is between 2000 and 2068 (inclusive). |
4 participants
@gostak-dd: This is a reconstruction of pr #134438 after I messed it up with web merge, built by cherry picking all the commits and resolving the conflicts with current main.
email.utils.parsedate_to_datetimeseem to differ from RFC2822 spec #126845