Fix crash on invalid recursive variadic alias#21572
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Jun 1, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21125
This one was tricky. This is because the above issue actually exposed two different crash scenarios:
*tuple[Ts](must be*tuple[*Ts]).And while working on this I discovered two more cases:
I fix the first by tightening logic in
typeanal.pyw.r.t. where exactly aTypeVarTupleis allowed. I fix the second and third by avoidingget_proper_type()calls inexpand_type()for recursive tuples. The fourth is the most problematic, and is kind of a fundamental thing. This PR only avoids an immediate crash for such aliases. We will still need to update various call sites where we special-case tuples to expect non-normal ones.Couple more related things:
is_recursivecache invalidation.detect_diverging_alias()to avoid creating sets unless really needed.