fix(slack): request reactions:read in OAuth URL, drop im:history#4856
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview The Slack connect flow now requests The read-messages API Reviewed by Cursor Bugbot for commit 0543dcc. Configure here. |
Greptile SummaryThis PR reconciles Sim's Slack OAuth scope set following Slack Marketplace reviewer feedback:
Confidence Score: 5/5Safe to merge — both changed files contain correct, minimal scope adjustments with no logic changes beyond an error message rewrite. The diff is two targeted changes: a scope array update in the OAuth config and an error message string update. The scope removal and addition are both well-justified and consistent with the rest of the codebase. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "chore(slack): update read-messages missi..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0543dcc. Configure here.
Summary
Reconciles the Slack OAuth scope set with Slack Marketplace reviewer feedback (June 2):
reactions:read— it was configured in the Slack app settings (and powers the reaction trigger) but missing from the OAuth URL, which the reviewer flagged.im:history— a bot can't be added to a human-to-human DM, soim:historyonly powers the App Home Messages tab (now disabled). Our "Read Messages from a DM" justification didn't hold; per the reviewer, the scope is removed.im:write/im:readare retained (opening/identifying a DM to send a message), and were not flagged.Note: also remove
im:historyfrom the Slack app dashboard bot scopes to match.Type of Change
Testing
biomepasses. Scope-only change.Checklist